all: enable makezero errchkjson noctx linters - #23174
Open
Sahil-4555 wants to merge 6 commits into
Open
Conversation
Sahil-4555
requested review from
AskAlexSharov,
anacrolix,
awskii,
domiwei,
lupin012,
mh0lt,
sudeepdino008,
taratorio and
yperbasis
as code owners
August 11, 2026 10:24
Sahil-4555
force-pushed
the
linter/enable-makezero-errchkjson-noctx
branch
2 times, most recently
from
August 11, 2026 11:14
0e41ec1 to
8f05b71
Compare
Sahil-4555
force-pushed
the
linter/enable-makezero-errchkjson-noctx
branch
from
August 12, 2026 04:23
8f05b71 to
690cc6b
Compare
…ero-errchkjson-noctx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables 3 bug-catching linter rules in
.golangci.yml(makezero,errchkjson, andnoctx) and resolves all existing violations across the codebase to ensure continuous CI protection against subtle runtime bugs.1.
makezeromake([]T, n)is followed byappend(), which unintentionally prependsnzero-value items at the beginning of a slice.2.
errchkjsonjson.Marshal,json.MarshalIndent, orjson.Encoder.Encodefailing silently when structs contain unsupported types, custom marshalers, or map keys.3.
noctxhttp.NewRequestinstead of context-aware functions.